Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enabling bulk actions for event definitions. #21238

Merged
merged 4 commits into from
Dec 27, 2024
Merged

Enabling bulk actions for event definitions. #21238

merged 4 commits into from
Dec 27, 2024
+27 −23

Conversation

dennisoelkers
Copy link
Member

@dennisoelkers dennisoelkers commented Dec 23, 2024 •
edited
Loading

Description

Motivation and Context

This PR is enabling bulk actions for event definitions on the general perspective.

How Has This Been Tested?

Screenshots (if appropriate):

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@dennisoelkers dennisoelkers force-pushed the feat/enable-bulk-actions-for-event-definitions branch from 84baace to 5339ba0 Compare December 23, 2024 12:52
maxiadlovskii
maxiadlovskii reviewed Dec 27, 2024
View reviewed changes
Copy link
Contributor

@maxiadlovskii maxiadlovskii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to use delete. It's not always work. If deleting one of the items fails, the response has 200 and we don't show any message. we have to handle this special case.
Screenshot 2024-12-27 at 10 47 59

@dennisoelkers
Copy link
Member Author

@maxiadlovskii: What is the reason in your example why it cannot delete the event definition?

@maxiadlovskii maxiadlovskii self-requested a review December 27, 2024 10:43
@maxiadlovskii maxiadlovskii merged commit f1c71e6 into master Dec 27, 2024
7 checks passed
@maxiadlovskii maxiadlovskii deleted the feat/enable-bulk-actions-for-event-definitions branch December 27, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxiadlovskii maxiadlovskii maxiadlovskii approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dennisoelkers @maxiadlovskii